Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DataRow Sendable #250

Merged
merged 2 commits into from
Mar 11, 2022
Merged

Conversation

fabianfett
Copy link
Collaborator

Motivation

For Swift 5.6, we want to support Sendable checks. DataRow generates a lot of warnings in CI today.

Changes

  • Make DataRow Sendable

@fabianfett fabianfett requested a review from gwynne March 9, 2022 09:09
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2022

Codecov Report

Merging #250 (efd07c2) into main (1cd8d36) will increase coverage by 3.96%.
The diff coverage is n/a.

❗ Current head efd07c2 differs from pull request most recent head 80acc05. Consider uploading reports for the commit 80acc05 to get more accurate results

@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   39.78%   43.75%   +3.96%     
==========================================
  Files         115      115              
  Lines        9513     9512       -1     
==========================================
+ Hits         3785     4162     +377     
+ Misses       5728     5350     -378     
Flag Coverage Δ
unittests 43.75% <ø> (+3.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Sources/PostgresNIO/New/Messages/DataRow.swift 95.38% <ø> (+4.61%) ⬆️
...ces/PostgresNIO/New/Data/Int+PostgresCodable.swift 30.71% <0.00%> (-1.31%) ⬇️
...es/PostgresNIO/Connection/PostgresConnection.swift 15.42% <0.00%> (-1.13%) ⬇️
Sources/PostgresNIO/New/PostgresQuery.swift 86.66% <0.00%> (ø)
Sources/PostgresNIO/New/PostgresCodable.swift 91.66% <0.00%> (ø)
...es/PostgresNIO/New/Data/Date+PostgresCodable.swift 89.28% <0.00%> (ø)
...es/PostgresNIO/New/Data/JSON+PostgresCodable.swift 100.00% <0.00%> (ø)
...es/PostgresNIO/New/Data/UUID+PostgresCodable.swift 98.30% <0.00%> (ø)
...s/PostgresNIO/New/Extensions/ByteBuffer+PSQL.swift 100.00% <0.00%> (ø)
.../PostgresNIO/New/Data/String+PostgresCodable.swift 100.00% <0.00%> (ø)
... and 31 more

@@ -116,3 +120,7 @@ extension DataRow {
return self[byteIndex]
}
}

#if swift(>=5.6)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 5.6 rather than 5.5?

Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marching onward!

@fabianfett fabianfett merged commit 8e341c1 into vapor:main Mar 11, 2022
@fabianfett fabianfett deleted the ff-make-DataRow-Sendable branch March 13, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants