Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating PostgresDataConvertible, PostgresMessageType #313

Merged
merged 4 commits into from
Apr 20, 2023

Conversation

fabianfett
Copy link
Collaborator

Motivation

We want to inform users of patterns that will be going away.

Changes

  • deprecate PostgresDataConvertible
  • deprecate PostgresMessageType
  • deprecate PostgresJSONCodable
  • deprecate PostgresJSONBCodable

Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecating PostgresDataConvertible would cause postgres-kit to emit multiple deprecation warnings in anything using it (typically via Fluent) which users would have no way to silence. @0xTim any thoughts?

@gwynne gwynne requested a review from 0xTim October 21, 2022 11:10
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2023

Codecov Report

Merging #313 (6eb244e) into main (606c68a) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 6eb244e differs from pull request most recent head eac6716. Consider uploading reports for the commit eac6716 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #313   +/-   ##
=======================================
  Coverage   41.27%   41.27%           
=======================================
  Files         115      115           
  Lines        9572     9572           
=======================================
  Hits         3951     3951           
  Misses       5621     5621           
Impacted Files Coverage Δ
Sources/PostgresNIO/Data/PostgresData+Array.swift 0.00% <0.00%> (ø)
Sources/PostgresNIO/Data/PostgresData+Bool.swift 0.00% <ø> (ø)
Sources/PostgresNIO/Data/PostgresData+Bytes.swift 0.00% <ø> (ø)
Sources/PostgresNIO/Data/PostgresData+Date.swift 0.00% <ø> (ø)
...ources/PostgresNIO/Data/PostgresData+Decimal.swift 0.00% <ø> (ø)
Sources/PostgresNIO/Data/PostgresData+Double.swift 0.00% <ø> (ø)
Sources/PostgresNIO/Data/PostgresData+Float.swift 0.00% <ø> (ø)
Sources/PostgresNIO/Data/PostgresData+Int.swift 0.00% <ø> (ø)
Sources/PostgresNIO/Data/PostgresData+JSON.swift 61.90% <ø> (ø)
Sources/PostgresNIO/Data/PostgresData+JSONB.swift 88.23% <ø> (ø)
... and 16 more

... and 2 files with indirect coverage changes

Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will be unblocked by completion of vapor/postgres-kit#237, at that time there are no further objections to merging it.

@fabianfett fabianfett merged commit c996d62 into vapor:main Apr 20, 2023
@fabianfett fabianfett deleted the ff-deprecate branch April 24, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants