-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecating PostgresDataConvertible, PostgresMessageType #313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecating PostgresDataConvertible
would cause postgres-kit
to emit multiple deprecation warnings in anything using it (typically via Fluent) which users would have no way to silence. @0xTim any thoughts?
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #313 +/- ##
=======================================
Coverage 41.27% 41.27%
=======================================
Files 115 115
Lines 9572 9572
=======================================
Hits 3951 3951
Misses 5621 5621
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR will be unblocked by completion of vapor/postgres-kit#237, at that time there are no further objections to merging it.
a29dccb
to
27b0632
Compare
Motivation
We want to inform users of patterns that will be going away.
Changes
PostgresDataConvertible
PostgresMessageType
PostgresJSONCodable
PostgresJSONBCodable