Use NIOThrowingAsyncSequenceProducer #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
==========================================
- Coverage 43.52% 41.76% -1.76%
==========================================
Files 115 115
Lines 9763 9408 -355
==========================================
- Hits 4249 3929 -320
+ Misses 5514 5479 -35
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FranzBusch
reviewed
Oct 26, 2022
| case .asyncSequence(let consumer, let dataSource): | ||
| let error = PSQLError.connectionClosed | ||
| case .asyncSequence(let source, let dataSource): | ||
| let error = CancellationError() |
There was a problem hiding this comment.
I don't fully agree with the usage of CancellationError here. It should only get thrown if the task is cancelled; however, in your code path it code be thrown when the source terminated the sequence where this would be quite confusing for the user. In general, you don't have to call source.finish as a result of didTerminate at all.
FranzBusch
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We should use components from NIO where possible and not rely on our own. Learnings from PostgresNIO have influenced the new very shiny
NIOThrowingAsyncSequenceProducer. We should adopt sooner rather than later.Changes
NIOThrowingAsyncSequenceProducerand drop our ownAsyncStreamConsumerResult
We support task cancellation on
iterator.next()