Add new protocol PostgresNonThrowingEncodable #322
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently creating a
PostgresQuery
through String interpolation always throws. The reason to support throwing inPostgresEncodable
is, that theEncodable
protocol enforces throwing (and we do want to support JSON). But for most of the primary types throwing is totally useless.Changes
PostgresNonThrowingEncodable
, which inherits fromPostgresEncodable
but enforces that theencode
method does notthrow
PostgresNonThrowingEncodable
inPostgresQuery
andPostgresBinding
to reduce the number of places where we throwResult
throw