Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various cleanups to CI #359

Merged
merged 2 commits into from
May 5, 2023
Merged

Various cleanups to CI #359

merged 2 commits into from
May 5, 2023

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented May 3, 2023

  • Don't need the BUILDING_DOCC hack (and thus the extra exports check CI job) anymore.
  • MASSIVELY simplify the projectboard workflow.
  • Reenable CI coverage for the main nightly snapshot since the bug that was crashing the compiler's been fixed.

@gwynne gwynne requested review from fabianfett and 0xTim May 3, 2023 12:29
@gwynne gwynne self-assigned this May 3, 2023
@gwynne
Don't need the BUILDING_DOCC hack (and thus the extra exports check C…
5a9e152 
…I job) anymore. MASSIVELY simplify the projectboard workflow. Reenable CI coverage for the main nightly snapshot since the bug that was crashing the compiler's been fixed.
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2023 •
edited
Loading

Codecov Report

Merging #359 (5a9e152) into main (dd1b740) will not change coverage.
The diff coverage is n/a.

❗ Current head 5a9e152 differs from pull request most recent head 1f6ea95. Consider uploading reports for the commit 1f6ea95 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #359   +/-   ##
=======================================
  Coverage   42.56%   42.56%           
=======================================
  Files         117      117           
  Lines        9695     9695           
=======================================
  Hits         4127     4127           
  Misses       5568     5568

fabianfett
fabianfett approved these changes May 3, 2023
View reviewed changes
Copy link
Collaborator

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwynne gwynne merged commit e4cc928 into main May 5, 2023
@gwynne gwynne deleted the ci-cleanup-number-NaN branch May 5, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianfett fabianfett fabianfett approved these changes

@0xTim 0xTim 0xTim approved these changes

Assignees

@gwynne gwynne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gwynne @codecov-commenter @fabianfett @0xTim