Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional connection parameters #361

Merged
merged 5 commits into from
Dec 12, 2023

Conversation

fabianfett
Copy link
Collaborator

Fixes: #320.

@jefflewis can you please check if this fixes your use-case?

@fabianfett fabianfett force-pushed the ff-support-additional-parameters branch from 90c0302 to bb7d83d Compare May 5, 2023 06:39
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2023

Codecov Report

Merging #361 (72d06bf) into main (e60e495) will increase coverage by 0.11%.
The diff coverage is 91.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
+ Coverage   59.81%   59.93%   +0.11%     
==========================================
  Files         124      124              
  Lines        9915     9937      +22     
==========================================
+ Hits         5931     5956      +25     
+ Misses       3984     3981       -3     
Files Coverage Δ
.../Connection/PostgresConnection+Configuration.swift 50.00% <100.00%> (+0.70%) ⬆️
...urces/PostgresNIO/New/PostgresChannelHandler.swift 84.77% <100.00%> (ø)
...stgresNIO/New/PostgresFrontendMessageEncoder.swift 100.00% <100.00%> (ø)
...nection State Machine/ConnectionStateMachine.swift 62.87% <86.66%> (+0.41%) ⬆️

... and 3 files with indirect coverage changes

@fabianfett fabianfett added this to the 2.0.0 milestone Aug 7, 2023
@fabianfett fabianfett force-pushed the ff-support-additional-parameters branch from bb7d83d to dca6bfe Compare August 10, 2023 07:04
@fabianfett fabianfett added the semver-minor Adds new public API. label Aug 10, 2023
@fabianfett fabianfett force-pushed the ff-support-additional-parameters branch from 6e1bf10 to 4365c6b Compare August 11, 2023 07:20
@fabianfett fabianfett force-pushed the ff-support-additional-parameters branch from 573573b to cc34fde Compare August 30, 2023 08:34
@fabianfett fabianfett marked this pull request as ready for review December 12, 2023 15:26
@fabianfett fabianfett merged commit fa3137d into vapor:main Dec 12, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing connection options for database
3 participants