Add PSQLError debugDescription #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ance to PostgresQuery, PostgresBindings.Metadata, and PostgresBindings.
…ror.debugDescription`. Remove workaround for missing ByteBuffer conformance (it's not missing anymore).
fabianfett
reviewed
Jun 2, 2023
…ror descriptions. Several tweaks to PostgresQuery and PostgresBindings descriptions to make them a bit less unwieldy, since devs are likely to see them a lot even if end-users don't.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #372 +/- ##
==========================================
+ Coverage 42.98% 44.35% +1.36%
==========================================
Files 118 118
Lines 8243 8629 +386
==========================================
+ Hits 3543 3827 +284
- Misses 4700 4802 +102
|
fabianfett
reviewed
Jun 8, 2023
gwynne
commented
Jun 9, 2023
fabianfett
approved these changes
Jun 9, 2023
This was referenced Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #354, #380. Continues work from #356 and #360.
Requires minor version bump (adds new public API in the form of protocol conformances).