Crash fix: Multiple bad messages could trigger reentrancy issue #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we receive multiple unexpected messages from the backend we can run into a reentrency situation in which we still have unread messages in the incomming buffer after we have received `channelInactive`. This pr patches this crash.
gwynne
approved these changes
Aug 3, 2023
| // We might run into this case because of reentrancy. For example: After we received an | ||
| // backend unexpected message, that we read of the wire, we bring this connection into | ||
| // the error state and will try to close the connection. The call to close() might be | ||
| // executed sync. This means that we received a `channelInactive` before we |
gwynne
approved these changes
Aug 3, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #379 +/- ##
==========================================
+ Coverage 44.35% 44.44% +0.09%
==========================================
Files 118 118
Lines 8630 8639 +9
==========================================
+ Hits 3828 3840 +12
+ Misses 4802 4799 -3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we receive multiple unexpected messages from the backend we can run into a reentrency situation in which we still have unread messages in the incomming buffer after we have received
channelInactive. This pr patches this crash.Fixes the crash mentioned in #374.