Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few inaccurate or confusing precondition failure messages #398

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Fix a few inaccurate or confusing precondition failure messages #398

merged 1 commit into from
Aug 18, 2023

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Aug 18, 2023 •
edited by MahdiBM
Loading

More for code clarity than anything else, really.

@gwynne gwynne added enhancement New feature or request semver-noop No version bump required. labels Aug 18, 2023
@gwynne gwynne requested a review from fabianfett August 18, 2023 17:39
fabianfett
fabianfett approved these changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwynne gwynne merged commit 12584c6 into main Aug 18, 2023
13 checks passed
@gwynne gwynne deleted the gwynne-patch-1 branch August 18, 2023 18:54
@fabianfett fabianfett added semver-patch No public API change. and removed semver-noop No version bump required. labels Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianfett fabianfett fabianfett approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request semver-patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gwynne @fabianfett