Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PoolStateMachine.ConnectionGroup (#425) #426

Merged
merged 5 commits into from
Oct 23, 2023
Merged

Add PoolStateMachine.ConnectionGroup (#425) #426

merged 5 commits into from
Oct 23, 2023

Conversation

fabianfett
Copy link
Collaborator

No description provided.

gwynne
gwynne reviewed Oct 20, 2023
View reviewed changes
Sources/ConnectionPoolModule/PoolStateMachine+ConnectionGroup.swift Outdated Show resolved Hide resolved
Sources/ConnectionPoolModule/PoolStateMachine+ConnectionGroup.swift Show resolved Hide resolved
Sources/ConnectionPoolModule/PoolStateMachine+ConnectionGroup.swift Outdated Show resolved Hide resolved
Sources/ConnectionPoolModule/PoolStateMachine+ConnectionGroup.swift Outdated Show resolved Hide resolved
Sources/ConnectionPoolModule/PoolStateMachine+ConnectionGroup.swift Outdated Show resolved Hide resolved
Sources/ConnectionPoolModule/PoolStateMachine+ConnectionGroup.swift Outdated Show resolved Hide resolved
Sources/ConnectionPoolModule/PoolStateMachine+ConnectionGroup.swift Outdated Show resolved Hide resolved
Sources/ConnectionPoolModule/PoolStateMachine+ConnectionGroup.swift Outdated Show resolved Hide resolved
@fabianfett fabianfett added this to the ConnectionPool milestone Oct 20, 2023
@fabianfett fabianfett added the semver-patch No public API change. label Oct 20, 2023
@fabianfett fabianfett marked this pull request as ready for review October 23, 2023 09:10
@codecov-commenter
Copy link

Codecov Report

Merging #426 (71774a9) into main (20a8c34) will increase coverage by 1.04%.
The diff coverage is 72.45%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
+ Coverage   56.99%   58.03%   +1.04%     
==========================================
  Files         119      120       +1     
  Lines        8410     8843     +433     
==========================================
+ Hits         4793     5132     +339     
- Misses       3617     3711      +94
Files Coverage Δ
Sources/ConnectionPoolModule/Max2Sequence.swift 100.00% <100.00%> (ø)
...ources/ConnectionPoolModule/PoolStateMachine.swift 16.66% <ø> (+16.66%) ⬆️
...nPoolModule/PoolStateMachine+ConnectionGroup.swift 82.36% <82.36%> (ø)
...nPoolModule/PoolStateMachine+ConnectionState.swift 69.72% <42.10%> (-7.10%) ⬇️

... and 2 files with indirect coverage changes

@fabianfett fabianfett merged commit 17d3c80 into vapor:main Oct 23, 2023
13 checks passed
@fabianfett fabianfett deleted the ff-pool-ConnectionGroup branch October 23, 2023 09:20
@fabianfett fabianfett added the ConnectionPool Features and bugs that are related to the impl in ConnectionPoolModule label Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwynne gwynne gwynne approved these changes

Assignees
No one assigned
Labels
ConnectionPool Features and bugs that are related to the impl in ConnectionPoolModule semver-patch No public API change.
Projects
None yet
Milestone
ConnectionPool
Development

Successfully merging this pull request may close these issues.
3 participants
@fabianfett @codecov-commenter @gwynne