Land PostgresClient that is backed by a ConnectionPool as SPI #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #430 +/- ##
=======================================
Coverage ? 58.83%
=======================================
Files ? 124
Lines ? 9792
Branches ? 0
=======================================
Hits ? 5761
Misses ? 4031
Partials ? 0
|
gwynne
requested changes
Oct 28, 2023
| /// The server to connect to | ||
| /// | ||
| /// - Default: localhost | ||
| public var host: String = "localhost" |
| let pool: Pool | ||
|
|
||
| public init(configuration: Configuration, eventLoopGroup: EventLoopGroup, backgroundLogger: Logger) throws { | ||
| let connectionConfig = try PostgresConnection.Configuration(configuration) |
There was a problem hiding this comment.
Variant that uses the singleton ELG?
| clientConfig.pool.keepAliveFrequency = .seconds(5) | ||
| clientConfig.pool.connectionIdleTimeout = .seconds(15) | ||
|
|
||
| clientConfig.server.host = env("POSTGRES_HOSTNAME") ?? "localhost" |
There was a problem hiding this comment.
Need to respect POSTGRES_PORT too.
|
|
||
| init(keepAliveFrequency: Duration?, logger: Logger) { | ||
| self.keepAliveFrequency = keepAliveFrequency | ||
| self.query = "SELECT 1;" |
There was a problem hiding this comment.
Shouldn't this be configurable via the corresponding client config field?
fabianfett
force-pushed
the
ff-PostgresClient
branch
from
93640f8
to
e7022fa
Compare
fabianfett
added
the
ConnectionPool
|
Crashing compiler toolchain in nightly. Ignore for now. |
gwynne
requested changes
Oct 30, 2023
|
|
||
| var connectionConfig: PostgresConnection.Configuration | ||
| switch config.endpointInfo { | ||
| case .bindUnixDomainSocket(let path): |
There was a problem hiding this comment.
Come to think of it, how about the "existing Channel" thing too?
There was a problem hiding this comment.
How do we want to use a single Channel for multiple connections. We will need to come up with a custom factory. That is a valuable goal. But not today.
| } | ||
| } | ||
|
|
||
| public func withConnection<Result>(_ closure: (PostgresConnection) async throws -> Result) async throws -> Result { |
Co-authored-by: Gwynne Raskind <gwynne@darkrainfall.org>
gwynne
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.