Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Removals for v2 #445

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Draft: Removals for v2 #445

wants to merge 20 commits into from

Conversation

fabianfett
Copy link
Collaborator

This is a quick and dirty draft of the removals that we want to do for v2. Happy to split this into smaller prs (see commits).

@fabianfett fabianfett added semver-major Breaks existing public API. breaking To fix this bug or implement this feature we must break API labels Dec 13, 2023
@fabianfett fabianfett added this to the 2.0.0 milestone Dec 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2023

Codecov Report

Attention: Patch coverage is 59.43396% with 43 lines in your changes missing coverage. Please review.

Project coverage is 63.47%. Comparing base (7b621c1) to head (0d938bf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
+ Coverage   54.98%   63.47%   +8.49%     
==========================================
  Files         127       77      -50     
  Lines       10155     8614    -1541     
==========================================
- Hits         5584     5468     -116     
+ Misses       4571     3146    -1425     
Files Coverage Δ
.../Connection/PostgresConnection+Configuration.swift 52.17% <ø> (ø)
Sources/PostgresNIO/Data/PostgresDataType.swift 54.92% <ø> (-0.26%) ⬇️
Sources/PostgresNIO/Data/PostgresNumeric.swift 75.90% <ø> (ø)
Sources/PostgresNIO/Data/PostgresRow.swift 71.42% <ø> (+22.72%) ⬆️
...tion State Machine/ExtendedQueryStateMachine.swift 77.20% <100.00%> (ø)
... State Machine/PreparedStatementStateMachine.swift 91.83% <100.00%> (ø)
Sources/PostgresNIO/New/PSQLEventsHandler.swift 73.58% <ø> (ø)
Sources/PostgresNIO/New/PSQLTask.swift 77.14% <100.00%> (ø)
Sources/PostgresNIO/New/PostgresQuery.swift 81.96% <ø> (+1.19%) ⬆️
Sources/PostgresNIO/Utilities/NIOUtils.swift 0.00% <ø> (ø)
... and 11 more

... and 2 files with indirect coverage changes

# Conflicts:
#	Sources/PostgresNIO/Data/PostgresDataType.swift
#	Sources/PostgresNIO/Docs.docc/index.md
#	Sources/PostgresNIO/Message/PostgresMessage+Identifier.swift
#	Sources/PostgresNIO/New/PostgresChannelHandler.swift
#	Sources/PostgresNIO/Utilities/Exports.swift
#	Sources/PostgresNIO/Utilities/PostgresError+Code.swift
#	Tests/IntegrationTests/PostgresNIOTests.swift
#	Tests/PostgresNIOTests/New/Extensions/ConnectionAction+TestUtils.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking To fix this bug or implement this feature we must break API semver-major Breaks existing public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants