Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be resilient about a read after connection closed; fixes #449 #452

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

fabianfett
Copy link
Collaborator

No description provided.

@fabianfett fabianfett added the semver-patch No public API change. label Jan 31, 2024
Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️❤️❤️

@codecov-commenter
Copy link

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (e9b90b2) 62.18% compared to head (721b8e8) 62.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #452      +/-   ##
==========================================
+ Coverage   62.18%   62.28%   +0.09%     
==========================================
  Files         124      124              
  Lines        9936     9937       +1     
==========================================
+ Hits         6179     6189      +10     
+ Misses       3757     3748       -9     
Files Coverage Δ
...nection State Machine/ConnectionStateMachine.swift 63.48% <63.15%> (+0.38%) ⬆️

... and 2 files with indirect coverage changes

@fabianfett fabianfett merged commit 69ccfdf into main Jan 31, 2024
12 of 13 checks passed
@fabianfett fabianfett deleted the ff-fix-449 branch January 31, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants