Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #454

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Fix warnings #454

merged 2 commits into from
Feb 21, 2024

Conversation

fabianfett
Copy link
Collaborator

Fix warnings:

  1. Use non deprecated NIOThrowingAsyncSequenceProducer factory method
  2. Remove UInt8's conformance to ExpressibleByUnicodeScalarLiteral
  3. Fix @retroactive conformance issues in test by fully specifying all types

@fabianfett fabianfett added the semver-patch No public API change. label Feb 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2024

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (69ccfdf) 62.28% compared to head (35f5192) 62.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #454      +/-   ##
==========================================
- Coverage   62.28%   62.27%   -0.01%     
==========================================
  Files         124      124              
  Lines        9937     9936       -1     
==========================================
- Hits         6189     6188       -1     
  Misses       3748     3748              
Files Coverage Δ
Sources/PostgresNIO/New/PSQLRowStream.swift 86.37% <100.00%> (+0.04%) ⬆️
...IO/Utilities/SASLAuthentication+SCRAM-SHA256.swift 47.20% <54.90%> (-0.29%) ⬇️

@fabianfett
Copy link
Collaborator Author

Breaking changes:

3 breaking changes detected in PostgresNIO:
  💔 API breakage: extension UInt8 has removed conformance to ExpressibleByUnicodeScalarLiteral
  💔 API breakage: constructor UInt8.init(unicodeScalarLiteral:) has been removed
  💔 API breakage: typealias UInt8.UnicodeScalarLiteralType has been removed

While those are actual breaking changes, it was 100% wrong that this is part of our public API and noone should have ever relied on this! @gwynne are you fine with deciding that this doesn't require a major version?

@fabianfett fabianfett added semver-minor Adds new public API. and removed semver-patch No public API change. labels Feb 21, 2024
@gwynne
Copy link
Member

gwynne commented Feb 21, 2024

@fabianfett The API breakage checker is more trouble than it's worth most of the time, the false positive rate is astronomical.

@fabianfett fabianfett merged commit 6433f6d into vapor:main Feb 21, 2024
11 of 13 checks passed
@fabianfett fabianfett deleted the ff-fix-warnings branch February 21, 2024 16:09
@fabianfett
Copy link
Collaborator Author

@gwynne this is not a false positive! We are really removing public API here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants