PostgresClient implements ServiceLifecycle's Service #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see any actual conformance here? |
fabianfett
force-pushed
the
ff-PostgresClient-implements-ServiceLifecycle
branch
from
47c215e
to
2eb5334
Compare
gwynne
approved these changes
Feb 21, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #457 +/- ##
==========================================
- Coverage 61.82% 61.81% -0.02%
==========================================
Files 125 125
Lines 10012 10014 +2
==========================================
Hits 6190 6190
- Misses 3822 3824 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostgresClientshould conform to ServiceLifecycle'sServiceto play nicely with the ecosystem.