Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PostgresClient API #460

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Make PostgresClient API #460

merged 1 commit into from
Feb 22, 2024

Conversation

fabianfett
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (c75349f) 61.86% compared to head (8c24d1f) 61.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
- Coverage   61.86%   61.82%   -0.05%     
==========================================
  Files         125      125              
  Lines       10014    10019       +5     
==========================================
- Hits         6195     6194       -1     
- Misses       3819     3825       +6     
Files Coverage Δ
Sources/PostgresNIO/Pool/PostgresClient.swift 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@fabianfett
Copy link
Collaborator Author

The breaking changes are on SPI:

2 breaking changes detected in PostgresNIO:
  💔 API breakage: func PostgresClient.query(_:logger:file:line:) has parameter 1 type change from Logging.Logger to Logging.Logger?
  💔 API breakage: func PostgresClient.execute(_:logger:file:line:) has parameter 1 type change from Logging.Logger to Logging.Logger?

@fabianfett fabianfett merged commit 7632411 into vapor:main Feb 22, 2024
11 of 13 checks passed
@fabianfett fabianfett deleted the ff-remove-spi branch February 22, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants