Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when recreating minimal connections #480

Merged
merged 1 commit into from
May 30, 2024

Conversation

fabianfett
Copy link
Collaborator

Thanks @lovetodream for the detailed bug report. Fixes #479.

@fabianfett fabianfett added the semver-patch No public API change. label May 30, 2024
@fabianfett fabianfett requested a review from gwynne May 30, 2024 11:26
@fabianfett fabianfett marked this pull request as ready for review May 30, 2024 11:26
@fabianfett fabianfett added the bug Something isn't working label May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.11%. Comparing base (d379584) to head (67d24d0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
+ Coverage   60.10%   60.11%   +0.01%     
==========================================
  Files         125      125              
  Lines        9174     9174              
==========================================
+ Hits         5514     5515       +1     
+ Misses       3660     3659       -1     
Files Coverage Δ
...nPoolModule/PoolStateMachine+ConnectionGroup.swift 87.53% <100.00%> (ø)

... and 1 file with indirect coverage changes

@fabianfett fabianfett merged commit ee669e9 into vapor:main May 30, 2024
13 checks passed
@fabianfett fabianfett deleted the ff-fix-479 branch May 30, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working semver-patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConnectionPool crash when minimum connections > 0
2 participants