Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Use Ubuntu 24.04 image, more code coverage, disable CodeQL completely #482

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Jun 13, 2024

  • When running Swift 5.10 images, use the Ubuntu 24.04 "Noble Numbat" image.
  • Upload code coverage for all Linux test runs, not just 5.10's; Codecov intelligently merges results. This makes coverage numbers more accurate.
  • Comment out the CodeQL job altogether rather than just skipping it so it doesn't clutter the Github UI.

@gwynne gwynne added the semver-noop No version bump required. label Jun 13, 2024
@gwynne gwynne requested a review from fabianfett June 13, 2024 17:00
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.07%. Comparing base (5c26876) to head (8e6e44a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #482      +/-   ##
==========================================
- Coverage   60.12%   55.07%   -5.06%     
==========================================
  Files         125      127       +2     
  Lines        9172    10155     +983     
==========================================
+ Hits         5515     5593      +78     
- Misses       3657     4562     +905     

see 5 files with indirect coverage changes

@gwynne gwynne enabled auto-merge (squash) June 13, 2024 17:08
@gwynne gwynne disabled auto-merge June 13, 2024 17:10
@gwynne gwynne merged commit e7b9a08 into main Jun 13, 2024
12 checks passed
@gwynne gwynne deleted the gwynne-patch-1 branch June 13, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-noop No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants