Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable StrictConcurrency checking #483

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Enable StrictConcurrency checking #483

merged 3 commits into from
Jun 14, 2024

Conversation

fabianfett
Copy link
Collaborator

No description provided.

@codecov Codecov
Copy link

codecov bot commented Jun 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.99%. Comparing base (6c3d0a9) to head (290e244).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #483   +/-   ##
=======================================
  Coverage   54.98%   54.99%           
=======================================
  Files         127      127           
  Lines       10155    10155           
=======================================
+ Hits         5584     5585    +1     
+ Misses       4571     4570    -1
Files Coverage Δ
Sources/ConnectionPoolModule/ConnectionPool.swift 94.49% <ø> (ø)
...olModule/ConnectionPoolObservabilityDelegate.swift 81.81% <ø> (ø)
...stgresNIO/Message/PostgresMessage+Identifier.swift 33.33% <ø> (ø)
...ces/PostgresNIO/Utilities/PostgresError+Code.swift 0.00% <ø> (ø)
Sources/PostgresNIO/Pool/PostgresClient.swift 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@fabianfett fabianfett changed the title More Swift 6 Sendable annotations Enable StrictConcurrency checking Jun 14, 2024
@fabianfett fabianfett marked this pull request as ready for review June 14, 2024 10:40
@fabianfett fabianfett requested a review from gwynne as a code owner June 14, 2024 10:40
@fabianfett
Copy link
Collaborator Author

Breaking changes only in ConnectionPool:

No breaking changes detected in PostgresNIO

13 breaking changes detected in _ConnectionPoolModule:
  💔 API breakage: struct NoOpConnectionPoolMetrics has generic signature change from <ConnectionID where ConnectionID : Swift.Hashable> to <ConnectionID where ConnectionID : Swift.Hashable, ConnectionID : Swift.Sendable>
  💔 API breakage: constructor NoOpConnectionPoolMetrics.init(connectionIDType:) has generic signature change from <ConnectionID where ConnectionID : Swift.Hashable> to <ConnectionID where ConnectionID : Swift.Hashable, ConnectionID : Swift.Sendable>
  💔 API breakage: func NoOpConnectionPoolMetrics.startedConnecting(id:) has generic signature change from <ConnectionID where ConnectionID : Swift.Hashable> to <ConnectionID where ConnectionID : Swift.Hashable, ConnectionID : Swift.Sendable>
  💔 API breakage: func NoOpConnectionPoolMetrics.connectFailed(id:error:) has generic signature change from <ConnectionID where ConnectionID : Swift.Hashable> to <ConnectionID where ConnectionID : Swift.Hashable, ConnectionID : Swift.Sendable>
  💔 API breakage: func NoOpConnectionPoolMetrics.connectSucceeded(id:streamCapacity:) has generic signature change from <ConnectionID where ConnectionID : Swift.Hashable> to <ConnectionID where ConnectionID : Swift.Hashable, ConnectionID : Swift.Sendable>
  💔 API breakage: func NoOpConnectionPoolMetrics.connectionUtilizationChanged(id:streamsUsed:streamCapacity:) has generic signature change from <ConnectionID where ConnectionID : Swift.Hashable> to <ConnectionID where ConnectionID : Swift.Hashable, ConnectionID : Swift.Sendable>
  💔 API breakage: func NoOpConnectionPoolMetrics.keepAliveTriggered(id:) has generic signature change from <ConnectionID where ConnectionID : Swift.Hashable> to <ConnectionID where ConnectionID : Swift.Hashable, ConnectionID : Swift.Sendable>
  💔 API breakage: func NoOpConnectionPoolMetrics.keepAliveSucceeded(id:) has generic signature change from <ConnectionID where ConnectionID : Swift.Hashable> to <ConnectionID where ConnectionID : Swift.Hashable, ConnectionID : Swift.Sendable>
  💔 API breakage: func NoOpConnectionPoolMetrics.keepAliveFailed(id:error:) has generic signature change from <ConnectionID where ConnectionID : Swift.Hashable> to <ConnectionID where ConnectionID : Swift.Hashable, ConnectionID : Swift.Sendable>
  💔 API breakage: func NoOpConnectionPoolMetrics.connectionClosing(id:) has generic signature change from <ConnectionID where ConnectionID : Swift.Hashable> to <ConnectionID where ConnectionID : Swift.Hashable, ConnectionID : Swift.Sendable>
  💔 API breakage: func NoOpConnectionPoolMetrics.connectionClosed(id:error:) has generic signature change from <ConnectionID where ConnectionID : Swift.Hashable> to <ConnectionID where ConnectionID : Swift.Hashable, ConnectionID : Swift.Sendable>
  💔 API breakage: func NoOpConnectionPoolMetrics.requestQueueDepthChanged(_:) has generic signature change from <ConnectionID where ConnectionID : Swift.Hashable> to <ConnectionID where ConnectionID : Swift.Hashable, ConnectionID : Swift.Sendable>
  💔 API breakage: typealias NoOpConnectionPoolMetrics.ConnectionID has generic signature change from <ConnectionID where ConnectionID : Swift.Hashable> to <ConnectionID where ConnectionID : Swift.Hashable, ConnectionID : Swift.Sendable>

@fabianfett fabianfett added the semver-patch No public API change. label Jun 14, 2024
@fabianfett fabianfett merged commit 7b621c1 into main Jun 14, 2024
10 of 11 checks passed
@fabianfett fabianfett deleted the ff-prepare-for-swift-6 branch June 14, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwynne gwynne gwynne approved these changes

Assignees
No one assigned
Labels
semver-patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabianfett @gwynne