Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Swift 5.7 #485

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Drop support for Swift 5.7 #485

merged 3 commits into from
Jun 14, 2024

Conversation

fabianfett
Copy link
Collaborator

To land #484, we must drop support for Swift 5.7.

@fabianfett fabianfett requested a review from gwynne as a code owner June 14, 2024 08:40
@fabianfett fabianfett added the semver-minor Adds new public API. label Jun 14, 2024
@gwynne
Copy link
Member

gwynne commented Jun 14, 2024

Don't forget to update the README badge

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.01%. Comparing base (e7b9a08) to head (e1b1586).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #485      +/-   ##
==========================================
- Coverage   55.07%   55.01%   -0.06%     
==========================================
  Files         127      127              
  Lines       10155    10155              
==========================================
- Hits         5593     5587       -6     
- Misses       4562     4568       +6     
Files Coverage Δ
Sources/ConnectionPoolModule/ConnectionPool.swift 94.49% <100.00%> (-4.13%) ⬇️
Sources/PostgresNIO/New/NotificationListener.swift 69.13% <ø> (ø)
...PostgresNIO/New/PostgresNotificationSequence.swift 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

@fabianfett fabianfett merged commit 5f541d0 into main Jun 14, 2024
11 checks passed
@fabianfett fabianfett deleted the ff-drop-support-for-5.7 branch June 14, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants