Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change 'unsafeDowncast' to 'as!' #495

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Change 'unsafeDowncast' to 'as!' #495

merged 1 commit into from
Jul 25, 2024

Commits on Jul 25, 2024

  1. Change 'unsafeDowncast' to 'as!' 

    Motivation:

The 'unsafeDowncast' can cause a miscompile leading to unexpected runtime behaviour.

Modifications:

- Use 'as!' instead

Result:

No miscompiles on 5.10
    @glbrntt
    glbrntt committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    60ad8b3 View commit details
    Browse the repository at this point in the history