Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[Fix] Query Hangs if Connection is Closed (#487)" #501

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Revert "[Fix] Query Hangs if Connection is Closed (#487)" #501

merged 1 commit into from
Aug 20, 2024

Conversation

fabianfett
Copy link
Collaborator

This reverts commit f55caa7.

@fabianfett fabianfett mentioned this pull request Aug 20, 2024
Open
@fabianfett fabianfett enabled auto-merge (squash) August 20, 2024 11:49
@codecov Codecov
Copy link

codecov bot commented Aug 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 54.99%. Comparing base (d18b137) to head (827a436).
Report is 1 commits behind head on main.

Files Patch % Lines
...es/PostgresNIO/Connection/PostgresConnection.swift 30.00% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
- Coverage   55.29%   54.99%   -0.31%     
==========================================
  Files         127      127              
  Lines       10162    10156       -6     
==========================================
- Hits         5619     5585      -34     
- Misses       4543     4571      +28
Files Coverage Δ
...es/PostgresNIO/Connection/PostgresConnection.swift 42.25% <30.00%> (-6.33%) ⬇️

... and 5 files with indirect coverage changes

@fabianfett fabianfett merged commit cd5318a into vapor:main Aug 20, 2024
9 of 11 checks passed
@fabianfett fabianfett deleted the ff-revert-#487 branch August 20, 2024 12:04
@fabianfett fabianfett added the semver-patch No public API change. label Aug 20, 2024
MahdiBM added a commit to MahdiBM/postgres-nio that referenced this pull request Sep 7, 2024
@MahdiBM
Reapply "[Fix] Query Hangs if Connection is Closed (vapor#487)" (vapo…
cd5d729 
…r#501)

This reverts commit cd5318a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MahdiBM MahdiBM MahdiBM approved these changes

@gwynne gwynne Awaiting requested review from gwynne gwynne is a code owner

Assignees
No one assigned
Labels
semver-patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabianfett @MahdiBM