Errors are now properly handled in build script #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xTim
reviewed
Mar 14, 2024
Makefile
Outdated
| @@ -1,6 +1,7 @@ | |||
| DEST := /usr/local/bin/vapor | |||
|
|
|||
| build: | |||
| swift build -c release | |||
There was a problem hiding this comment.
Is this needed? Seems a bit redundant
There was a problem hiding this comment.
I found that if I just built it without the release flag, it defaulted to debug.
Which ultimately changed the output folder.
There was a problem hiding this comment.
Right, sorry I mean why are we doing a build here at all? The build.swift script is the one doing the build
There was a problem hiding this comment.
Ah! Duh. Apologies, should be fixed up now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #449
Solves issue where building from source would hang indefinitely