-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Swift Versions #456
Conversation
We want to keep the toolbox compatible with 5.5 for users on old versions of macOS. I recently had to do a PR to restore that compatibility. There's no need to bump that minimum (though bumping the integration tests is a good idea). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment
Done, no need for a release then |
@0xTim Fixing the CI requires adding the same "we now need an available database server for the template's tests" logic to the toolbox CI that I added to the template's CI (see https://github.com/vapor/template/blob/main/.github/workflows/test-template.yml#L51-L118) |
How the hell has this ever passed in the past |
Those tests didn't previously exist so there was nothing to fail. |
Ohh right, we ran tests but didn't do anything in them. Makes sense |
Bumps the integration tests to 5.10 to match the template and the toolbox minimum Swift version to 5.8 to match Vapor