Skip to content

Commit

Permalink
lsan: add lsan suppressions file
Browse files Browse the repository at this point in the history
A memory leak pops up in our CI from time to time
(redpanda-data#3338). It is caused by
a very narrow race within Seastar when incoming connections arrive while
a socket server is being shutdown.

I've posted a "fix" for this in upstream Seastar (link below) which is
effectively rejected because it doesn't really fix the leak, but merely
cleans up on exit to make LSAN happy. AFAICT this leak can only happen
when a socket server is being shut down, and in Redpanda, this only
happens when Redpanda is shutting down. In this case it is harmless,
but annoying because it will occassionally fail our CI.

Adding an LSAN suppressions file allows us to instruct LSAN to ignore
this particular leak when it occassionally does trigger.

Fixes: redpanda-data#3338

See scylladb/seastar#1265 for more discussion
and a link to an issue with a reproducer.

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
(cherry picked from commit 778704b)
  • Loading branch information
dotnwat authored and vbotbuildovich committed Jan 27, 2023
1 parent 03d45e6 commit 3833212
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions lsan_suppressions.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
leak:seastar::net::conntrack::handle::~handle

0 comments on commit 3833212

Please sign in to comment.