Skip to content

Commit

Permalink
tests: update ClusterConfigTest to use valid URL
Browse files Browse the repository at this point in the history
Previously metrics reporter was only paying attention
to its url if switched on: now it runs all the time (although
only sending requests if it's switched on), so we need to
get this right.
  • Loading branch information
jcsp committed May 10, 2022
1 parent 992b1ed commit eff6561
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion tests/rptest/tests/cluster_config_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,10 @@ def test_valid_settings(self):
else:
valid_value = 1000.0
elif p['type'] == 'string':
valid_value = "rhubarb"
if name.endswith("_url"):
valid_value = "http://example.com"
else:
valid_value = "rhubarb"
elif p['type'] == 'boolean':
valid_value = not initial_config[name]
elif p['type'] == "array" and p['items']['type'] == 'string':
Expand Down

0 comments on commit eff6561

Please sign in to comment.