Added function element_encode() #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks awesome, thanks! |
veewee
reviewed
Apr 30, 2022
| public function test_it_encodes_to_element(string $xml, array $data) | ||
| { | ||
| $actual = element_encode($data); | ||
| static::assertXmlStringEqualsXmlString($xml, $actual); |
There was a problem hiding this comment.
Maybe you can make sure the XML header is not available in the result here?
docs/encoding.md
Outdated
| @@ -32,6 +32,7 @@ The encoding components consist out of following functions | |||
|
|
|||
| - [document_encode](#document_encode): Encodes an array into a DOM [Document](dom.md). | |||
| - [element_decode](#element_decode): Decodes a DOMElement into an array. | |||
| - [element_encode](#element_encode): Encodes an array into an XML string. | |||
There was a problem hiding this comment.
This has the same comment as xml_encode, might be confusing for the developers
docs/encoding.md
Outdated
| @@ -93,6 +94,30 @@ In the example above, we run an XSD validator before parsing the XML into an arr | |||
|
|
|||
| More information about [the PHP format can be found here](#php-format). | |||
|
|
|||
| #### element_encode | |||
|
|
|||
| Encode transforms an array into an XML string. | |||
There was a problem hiding this comment.
Same here: looks like a better idea to differentiate and link between the two functions at the top.
|
Thank you for the feedback. I have made some changes accordingly. I hope the documentation is now a bit clearer as well. |
|
Yes it is. Thanks again for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary