Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow directives on variable definitions #135

Merged
merged 1 commit into from
Oct 22, 2020
Merged

allow directives on variable definitions #135

merged 1 commit into from
Oct 22, 2020

Conversation

vikstrous
Copy link
Contributor

This implements a missing part of the spec, identified by @vvakame. This seemed like an easy first contribution :) fix #102

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 92.06% when pulling 9914f67 on vikstrous:allow-directives into 83ee611 on vektah:master.

@lwc
Copy link
Collaborator

lwc commented Oct 22, 2020

Easy, thanks!

@lwc lwc merged commit bb603a3 into vektah:master Oct 22, 2020
@vikstrous vikstrous deleted the allow-directives branch October 22, 2020 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unimplemented spec: Allow directives on variable definitions
3 participants
@vikstrous @coveralls @lwc