Compare encoded bodies instead of data when possible Fixes #23 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,8 +13,20 @@ struct Cassette { | |||
| for interaction in interactions { | |||
| let r = interaction.request | |||
|
|
|||
| let equivalentBody: Bool | |||
|
|
|||
| if let rBody = r.HTTPBody, | |||
There was a problem hiding this comment.
Can we avoid the shortened vars here and just call this requestBody?
There was a problem hiding this comment.
Oh, derp. Just noticed we already have requestBody... I'm just confused by the naming. What is r vs. what is request?
There was a problem hiding this comment.
Maybe interactionRequestBody?
|
Nice fix! One question around variable naming and then 🍏 |
|
changed the naming and moved the HTTPBody equality check into into a private function |
|
LGTM. 🍏 |
|
One question then 🍏! |
dasmer
added a commit
that referenced
this pull request
Aug 10, 2015
Compare encoded bodies instead of data when possible Fixes #23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now unwrap the
HTTPBodyNSDatas into and compare usingisEqual