Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PodSpec Update: Sync to latest Release #89

Merged
merged 2 commits into from
Nov 8, 2018
Merged

PodSpec Update: Sync to latest Release #89

merged 2 commits into from
Nov 8, 2018

Conversation

dmiluski
Copy link
Contributor

@dmiluski dmiluski commented Nov 8, 2018 •
edited
Loading

  • Update Plist Version
  • Bump PodSpec Version
  • Update swift version

PodSpec Update: Sync to latest Release
4e2ab0e 
- Update Plist Version
- Bump PodSpec Version
- Udpate swift version
@dmiluski dmiluski requested review from eliperkins and hyperspacemark and removed request for eliperkins November 8, 2018 18:57
eliperkins
eliperkins reviewed Nov 8, 2018
View reviewed changes
Copy link
Contributor

@eliperkins eliperkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Make sure to push a new git tag too!

@dmiluski
Copy link
Contributor Author

dmiluski commented Nov 8, 2018

Updated to fresh version, will create Git Tag/Release once merged matching this version

@dmiluski dmiluski merged commit 5875e4a into venmo:master Nov 8, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliperkins eliperkins eliperkins left review comments

@hyperspacemark hyperspacemark hyperspacemark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmiluski @hyperspacemark @eliperkins