Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add webpack arg for customizing webpack config #1155

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

iamhollow
Copy link

This PR enables the base ncc webpack config to be customized or extended, similar to NextJS:

https://nextjs.org/docs/app/api-reference/next-config-js/webpack

The use cases of this feature are scenarios such as adding additional webpack rules or plugins, or configuring a path resolve alias.

The README has been updated for the programmatic invoke from Node.js to include the new webpack arg.

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

We don't want to expose anything specific to webpack because that will make it much harder to swap webpack to another bundler (such as turbopack) in the future.

@iamhollow
Copy link
Author

iamhollow commented Jan 29, 2024

@styfle @Timer I renamed the exposed variable to a more generic wrapper called "customizeConfig"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants