Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update build process dependencies #1192

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ilnicki
Copy link

@ilnicki ilnicki commented May 24, 2024

Current version of ncc refuses to build my project with not really helpfull error like:
node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:73627 resource: j.length > 1 ? j.map((E) => E.path) : j[0].path TypeError: Cannot read properties of undefined (reading 'path')
I've formatted index.js.cache.js for message to be more meaningfull.

Updating building dependencies fixes it.

@ilnicki ilnicki requested review from styfle and Timer as code owners May 24, 2024 16:58
@ilnicki ilnicki changed the title Update build process dependencies fix: Update build process dependencies May 24, 2024
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Can you add a test to verify this fixes the bug?

@macrozone
Copy link

i have the same error, can we get this merged? not sure if it fixes my error though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants