Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add pagination and more button at the bottom #58

Merged
merged 1 commit into from
Feb 11, 2023

Conversation

gfortaine
Copy link
Contributor

@gfortaine gfortaine commented Nov 14, 2022

Fixes #56

@vercel
Copy link

vercel bot commented Nov 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
next-rsc-news ✅ Ready (Inspect) Visit Preview Dec 23, 2022 at 1:20AM (UTC)

app/head.js Outdated
@@ -10,7 +10,7 @@ export default async function Head() {
/>
<meta charSet="utf-8" />
<link href="/favicon.ico" rel="shortcut icon" />
<meta content="#ffa52a" name="theme-color" />
<meta content="#ff6600" name="theme-color" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the original color, unless there's a specific reason here?

@leerob
Copy link
Member

leerob commented Nov 14, 2022

If you navigate backward from an individual item, you get a 404.

CleanShot 2022-11-13 at 18 56 50@2x

@gfortaine
Copy link
Contributor Author

If you navigate backward from an individual item, you get a 404.

CleanShot 2022-11-13 at 18 56 50@2x

vercel/next.js#40549

@leerob
Copy link
Member

leerob commented Feb 11, 2023

Thank you!

I think there's still more things we want to do here, like make the transition for page to page more seamless, and have a better loading skeleton for the individual item page, but this is a great start. I really appreciate it.

@leerob leerob merged commit 376bf27 into vercel:main Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pagination and "more" button at the bottom
2 participants