fix: add x-forwarded-* headers
#56797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balazsorban44
requested review from
a team,
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim,
ztanner and
wyattjoh
as code owners
balazsorban44
requested review from
manovotny and
lydiahallie
and removed request for
a team
ijjk
added
area: tests
created-by: Next.js team
Stats from current PRDefault BuildGeneral Overall increase
|
| vercel/next.js canary | vercel/next.js fix/x-forwarded-headers | Change | |
|---|---|---|---|
| buildDuration | 11.4s | 11.5s | N/A |
| buildDurationCached | 6.8s | 6.7s | N/A |
| nodeModulesSize | 172 MB | 172 MB | |
| nextStartRea..uration (ms) | 570ms | 560ms | N/A |
Client Bundles (main, webpack)
| vercel/next.js canary | vercel/next.js fix/x-forwarded-headers | Change | |
|---|---|---|---|
| 199-HASH.js gzip | 27.5 kB | 27.5 kB | N/A |
| 3f784ff6-HASH.js gzip | 50.9 kB | 50.9 kB | ✓ |
| 99.HASH.js gzip | 182 B | 182 B | ✓ |
| framework-HASH.js gzip | 45.3 kB | 45.3 kB | ✓ |
| main-app-HASH.js gzip | 254 B | 252 B | N/A |
| main-HASH.js gzip | 32.9 kB | 32.9 kB | N/A |
| webpack-HASH.js gzip | 1.75 kB | 1.75 kB | N/A |
| Overall change | 96.4 kB | 96.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | vercel/next.js fix/x-forwarded-headers | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | vercel/next.js fix/x-forwarded-headers | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 206 B | 205 B | N/A |
| _error-HASH.js gzip | 182 B | 180 B | N/A |
| amp-HASH.js gzip | 506 B | 505 B | N/A |
| css-HASH.js gzip | 322 B | 323 B | N/A |
| dynamic-HASH.js gzip | 2.57 kB | 2.57 kB | N/A |
| edge-ssr-HASH.js gzip | 260 B | 259 B | N/A |
| head-HASH.js gzip | 350 B | 350 B | ✓ |
| hooks-HASH.js gzip | 369 B | 369 B | ✓ |
| image-HASH.js gzip | 4.35 kB | 4.35 kB | N/A |
| index-HASH.js gzip | 256 B | 256 B | ✓ |
| link-HASH.js gzip | 2.64 kB | 2.63 kB | N/A |
| routerDirect..HASH.js gzip | 312 B | 311 B | N/A |
| script-HASH.js gzip | 385 B | 384 B | N/A |
| withRouter-HASH.js gzip | 307 B | 308 B | N/A |
| 1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
| Overall change | 1.08 kB | 1.08 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | vercel/next.js fix/x-forwarded-headers | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 485 B | 482 B | N/A |
| Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | vercel/next.js fix/x-forwarded-headers | Change | |
|---|---|---|---|
| index.html gzip | 528 B | 529 B | N/A |
| link.html gzip | 541 B | 542 B | N/A |
| withRouter.html gzip | 524 B | 524 B | ✓ |
| Overall change | 524 B | 524 B | ✓ |
Edge SSR bundle Size
| vercel/next.js canary | vercel/next.js fix/x-forwarded-headers | Change | |
|---|---|---|---|
| edge-ssr.js gzip | 93.8 kB | 93.8 kB | ✓ |
| page.js gzip | 152 kB | 152 kB | N/A |
| Overall change | 93.8 kB | 93.8 kB | ✓ |
Middleware size
| vercel/next.js canary | vercel/next.js fix/x-forwarded-headers | Change | |
|---|---|---|---|
| middleware-b..fest.js gzip | 624 B | 623 B | N/A |
| middleware-r..fest.js gzip | 150 B | 151 B | N/A |
| middleware.js gzip | 22.9 kB | 22.9 kB | N/A |
| edge-runtime..pack.js gzip | 1.92 kB | 1.92 kB | ✓ |
| Overall change | 1.92 kB | 1.92 kB | ✓ |
Tests Passed |
styfle
approved these changes
Oct 13, 2023
huozhi
approved these changes
Oct 13, 2023
|
this does not fix completly the issue it does fix for some seconds, after some tries will fail again |
1 task
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
### What? Follow-up of #56797 While working on this, I noticed that some logic around stripping internal headers was duplicated, so I did some cleanup too. ### Why? In #56797 we set these headers, but it only affected Route Handlers, Middleware is still missing them, which is a regression introduced in #52492 (Related: vercel/next-learn#252) ### How? Move to set these headers up to `base-server.ts` so they are present in Middleware too. > Note: All headers are set with `??=` to respect the original value if set (with other words, only add these headers if they aren't set yet) Closes NEXT- Fixes #52266
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adding back
x-forwarded-*headers.Why?
Starting with #52492, these headers were lost.
How?
We can populate these headers before executing a request.
Closes NEXT-1663
Fixes #55942