Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - highcharts multi-density plot #652

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Bug - highcharts multi-density plot #652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions verticapy/plotting/_highcharts/density.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ def draw(
"""
Draws a multi-density plot using the HC API.
"""
labels = self._clean_quotes(self.layout["labels"])
chart, style_kwargs = self._get_chart(chart, style_kwargs=style_kwargs)
chart.set_dict_options(self.init_style)
chart.set_dict_options(style_kwargs)
Expand All @@ -128,5 +127,5 @@ def draw(
data = np.column_stack(
(self.data["X"][:, i], self.data["Y"][:, i])
).tolist()
chart.add_data_set(data, "area", labels[i])
chart.add_data_set(data, "area", str(self.layout["labels"][i]))
return chart
15 changes: 0 additions & 15 deletions verticapy/tests_new/plotting/highcharts/test_highcharts_density.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,26 +32,11 @@ class TestHighchartsVDCDensityPlot(VDCDensityPlot):
"""


@pytest.mark.skip("Error in this highchart plot")
class TestHighchartVDCDensityMultiPlot(VDCDensityMultiPlot):
"""
Testing different attributes of Multiple Density plots on a vDataColumn
"""

def test_properties_multiple_plots_produced_for_multiplot(
self,
):
"""
Test if two plots created
"""
# Arrange
number_of_plots = 2
# Act
# Assert
assert (
len(self.result.lines) == number_of_plots
), "Two plots not produced for two classes"


class TestHighchartsVDFDensityPlot(VDFDensityPlot):
"""
Expand Down