Add Cause Exception When Wrapping OperationCanceledException Into InterruptedException

[HeikoKlare]

Current Behavior

At several places in the Eclipse Platform and JDT code, an OperationCanceledException is transformed into an InterruptedException. In many cases, the original exception is not added as the causing exception and in several cases not even the original message is passed to the new exception, e.g. here:

                } catch (OperationCanceledException e) {
                        throw new InterruptedException();
                } catch (CoreException e) {

Expected Behavior

Every InterruptedException thrown for an OperationCanceledException should use the original message and have the original exception as its cause.

• org.eclipse.core.tools.search.FindUnusedMembers
• org.eclipse.search2.internal.ui.InternalSearchUI
• org.eclipse.jface.operation.ModalContext (only wrong documentation)
• org.eclipse.ui.operations.OperationHistoryActionHandler
• org.eclipse.jdt.internal.core.builder.BuildNotifier
• org.eclipse.jdt.internal.corext.refactoring.rename.RenameTypeProcessor
• org.eclipse.jdt.internal.junit.ui.JUnitQuickFixProcessor
• org.eclipse.jdt.internal.junit.wizards.NewTestCaseCreationWizard
• org.eclipse.jdt.internal.ui.actions.WorkbenchRunnableAdapter
• org.eclipse.jdt.internal.ui.dialogs.PackageSelectionDialog
• org.eclipse.jdt.internal.ui.typehierarchy.TypeHierarchyLifeCycle
• org.eclipse.jdt.internal.ui.util.BusyIndicatorRunnableContext
• org.eclipse.jdt.internal.ui.wizards.buildpaths.ClasspathFixSelectionDialog
• org.eclipse.jdt.internal.ui.wizards.buildpaths.VariableBlock
• org.eclipse.jdt.ui.wizards.JavaCapabilityConfigurationPage
• org.eclipse.jdt.ui.wizards.NewJavaProjectWizardPage
• org.eclipse.jdt.ui.wizards.NewJavaProjectWizardPageTwo
• org.eclipse.jdt.internal.ui.refactoring.reorg.RenameTypeWizardInputPage
• org.eclipse.jdt.internal.ui.refactoring.RefactoringExecutionHelper

[fedejeanne]

See eclipse-platform/eclipse.platform#853

[HeikoKlare]

Platform UI:

• Pack the original OperationCanceledException in ModalContext::run eclipse-platform/eclipse.platform.ui#1259
• Initialize cause of some InterruptedExceptions eclipse-platform/eclipse.platform.ui#1301
• Wrapped the OperationCanceledException in InterruptedException eclipse-platform/eclipse.platform.ui#1364
• Remove obsolete comment eclipse-platform/eclipse.platform.ui#1387

JDT UI:

• Wrapped the OperationCanceledException in InterruptedException eclipse-jdt/eclipse.jdt.ui#967

[HeikoKlare]

What's the state of this? It is markes as "In Review" but no PR seems to be open on this. JDT findings have not been checked/resolved.