Wrapped the OperationCanceledException in InterruptedException #967
Conversation
| } catch (OperationCanceledException e1) { | ||
| throw new InterruptedException(); | ||
| InterruptedException interruptedException = new InterruptedException(e1.getLocalizedMessage()); | ||
| interruptedException.initCause(e1); | ||
| throw interruptedException; |
There was a problem hiding this comment.
No need to do this, remove this catch and add a | OperationCanceledException ("multi-catch") in line 182 (//user canceled)
| InterruptedException interruptedException = new InterruptedException(e.getLocalizedMessage()); | ||
| interruptedException.initCause(e); | ||
| throw interruptedException; |
There was a problem hiding this comment.
Not sure about this one: do you see any call where this exception would reach the UI or any log?
There was a problem hiding this comment.
This is used by the JavaProjectWizard which is provided by jdt.ui.
There was a problem hiding this comment.
I think this one is propagated to the user, I have traced the calls and seems like the methods are called in try-finally blocks in atleast one path.
| throw new InterruptedException(); | ||
| InterruptedException interruptedException = new InterruptedException(e2.getLocalizedMessage()); | ||
| interruptedException.initCause(e2); | ||
| throw interruptedException; |
There was a problem hiding this comment.
This one is only used in tests, no need to add the info here.
| InterruptedException interruptedException = new InterruptedException(e.getLocalizedMessage()); | ||
| interruptedException.initCause(e); | ||
| throw interruptedException; |
There was a problem hiding this comment.
Same as above: this one is being caught a few lines below so you can simply let it through and change the catch-clause below and make it a multi-catch:
catch (InterruptedException | OperationCanceledException e) {
// cancel pressed
}
amartya4256
force-pushed
the
master
branch
2 times, most recently
from
eaefba2
to
0e02c62
Compare
|
@amartya4256 did you close this one by accident? |
What it does
eclipse-platform/eclipse.platform#853
Wrapped the OperationCanceledException in InterruptedException
How to test
Author checklist