Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Kustomize v5.0.0 #170

Merged
merged 7 commits into from
Feb 8, 2023
Merged

Conversation

starcraft66
Copy link
Contributor

Kustomize 5.0.0 contains important fixes for loading remote resources and other stuff.

@devstein devstein self-requested a review February 7, 2023 04:31
Copy link
Collaborator

@devstein devstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@starcraft66 Thanks for making a PR! I love Starcraft 😁

Excited that there is a new kustomize release. Can you also update sigs.k8s.io/kustomize/api to v0.13.0 in the go.mod file and run go mod tidy?

We may also need to drop support for Go 1.18: kubernetes-sigs/kustomize#4877

@devstein devstein added the please code review Code review needed label Feb 7, 2023
@starcraft66
Copy link
Contributor Author

starcraft66 commented Feb 7, 2023

I love Starcraft 😁

That's awesome, glad to hear it! I do too obviously

Excited that there is a new kustomize release. Can you also update sigs.k8s.io/kustomize/api to v0.13.0 in the go.mod file and run go mod tidy?

We may also need to drop support for Go 1.18: kubernetes-sigs/kustomize#4877

I went ahead and did all of that, also fixed a couple unit tests that broke.

@@ -10,6 +10,4 @@ metadata:
# otherwise, path should be relative to manifest files, like
# path: ../../../ksops
files:
# NOTE: File is relative to the /base manifest!
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is actually a bug that was fixed in kubernetes-sigs/kustomize#4654

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! You're right

Copy link
Collaborator

@devstein devstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. Thank you for contributing!

@devstein devstein merged commit 4027090 into viaduct-ai:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please code review Code review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants