Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PrettyTableViewCell] Correctly initialize from a storyboard. #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fabiopelosin
Copy link

UIStoryboard calls initWithCoder:.

@vicpenap
Copy link
Owner

That's cool!

Have you tried the other cells too? They also have initialization code on initWithStyle: method.

@vicpenap vicpenap mentioned this pull request Jul 31, 2012
@fabiopelosin
Copy link
Author

I haven't tried the other cells but I think that the same logic applies.

One note, commonInit is often used in this scenario and experienced some difficulties after implemented this change because I was overriding it :-) What do you think about name-spacing it as prettyCommonInit?

@vicpenap
Copy link
Owner

vicpenap commented Aug 1, 2012

Ok, so the other cells would need to extract the initialization from
the constructor and add a new initWithCoder. Could you try that? I'm
not familiar with Storyboards, as I've been always giving support to
iOS 4 and as a result I've never used it.

It's ok for me to change the common initializer. You can choose
prettyCommonInit as suggest. It's your contribution, so feel free :)

@danil-z
Copy link

danil-z commented Jul 19, 2013

I'm affected of this issue too. i've merged this pull request and now custom cells works as expected from storyboards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants