Project modernisation

[kpmaalej]

iPhone 5 & iOS 6 compatibility, ARC, Storyboards.

Includes irrationalfab's patch from Jul 30th, 2012 and a full Storyboard example of my own.

[vicpenap]

Hei that's good! And moving to ARC is a must, it's true.

The only thing is that your ARC changes makes PrettyKit no longer compatible with 4.0. In my opinion, once we break 4.0 compatibility, we should start using UIAppearance.

That would be quite a big change, and I would like to support 4.0 a bit more, so what if the change to ARC is made still supporting 4.0? (weak attribute can't be used, for example)

[kpmaalej]

The Storyboard itself limits compatibility to iOS 5+. But the library itself can be kept compatible with iOS 4, true.

[vicpenap]

But your modifications don't force the use of storyboards, do them? I mean, what you changed was implementing initWithCoder, right? And that doesn't require iOS 5 at all, so the lib would be still compatible with iOS 4.

[kpmaalej]

Yes, that's exactly what I said: “the library itself can be kept compatible with iOS 4” :)

And that's what I just fixed, along with a couple other outstanding issues :)

[kpmaalej]

up :)

[bringel]

Is this ever going to get pulled into the project?

[vicpenap]

It will, eventually. I don't have enough time to update pretty kit, but I
definitely want to switch to ARC and make some other improvements as well.

In the meantime it will be better that you use your own fork instead.

On 19 Xan, 2013, at 23:25, Bradley Ringel notifications@github.com wrote:

Is this ever going to get pulled into the project?

—
Reply to this email directly or view it on
GitHubhttps://github.com//pull/32#issuecomment-12462328.