Fixed bug in SSR #1865
Closed
Fixed bug in SSR #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you explain what bug this is solving exactly and why we need this perf-hooks package now? :) some more explanation would be nice ;) |
|
Also, can you check if the issue addressed is fixed with #1841 ? WE merged this recently and it's supposed to do all the SSR magic. I don't see how it could be specifically related to performance, there are many other globals. We have a general solution with the PR merged above. |
|
i don't think we want to go for a solution that only addresses a subsection of the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
This PR will fix some bugs in SSR.
Why is this Pull Request needed?
This PR is needed to enable SSR.
Are there any points in the code the reviewer needs to double check?
Resolves issues:
#1863
Checklist