Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fragPrevious when attempting to load an already-buffered fragment #5013

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Update fragPrevious when attempting to load an already-buffered fragment #5013

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc44030
Update fragPrevious when attempting to load an already-buffered fragment
Nov 7, 2022
bdd9f0d
Move already buffered fragment logic to base-stream-controller
Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/controller/base-stream-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1058,7 +1058,8 @@ export default class BaseStreamController
end: number,
levelDetails: LevelDetails
): Fragment | null {
const { config, fragPrevious } = this;
const { config } = this;
let { fragPrevious } = this;
let { fragments, endSN } = levelDetails;
const { fragmentHint } = levelDetails;
const tolerance = config.maxFragLookUpTolerance;
Expand Down Expand Up @@ -1092,6 +1093,11 @@ export default class BaseStreamController

if (frag) {
const curSNIdx = frag.sn - levelDetails.startSN;
// Move fragPrevious forward to support forcing the next fragment to load
// when the buffer catches up to a previously buffered range.
if (this.fragmentTracker.getState(frag) === FragmentState.OK) {
fragPrevious = frag;
}
if (fragPrevious && frag.sn === fragPrevious.sn && !loadingParts) {
// Force the next fragment to load if the previous one was already selected. This can occasionally happen with
// non-uniform fragment durations
Expand Down