Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter variants with any unsupported codecs #5533

Merged

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Jun 2, 2023

This PR will...

Filter variants with multiple audio or video codecs where any of the codecs are unsupported by MSE.

Why is this Pull Request needed?

All codecs in the CODECS attribute must be supported for a client to select and play a variant.

Multiple video or audio codecs separated by a comma typically indicate codec changes at discontinuities in the stream (common with digital ad insertion). Multiple audio codecs can also indicate a variety of codecs across playlists within the same audio group. However, since the client can not determine which tracks contain which of the codecs, if any of them are unsupported, the client should not use the variant which could require all of them. For this reason using different audio groups for each audio codec is recommended.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

#5378

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

Base automatically changed from feature/mp4-codec-parsing to master June 2, 2023 20:24
@robwalch robwalch added this to the 1.5.0 milestone Jun 2, 2023
@robwalch robwalch merged commit f97f561 into master Jun 2, 2023
@robwalch robwalch deleted the bugfix/filter-variants-with-any-unsupported-codecs branch June 2, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant