Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check ManagedMediaSource removedRanges length on "bufferedchange" event #5915

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Oct 18, 2023

This PR will...

Check ManagedMediaSource removedRanges length on "bufferedchange" event.

Why is this Pull Request needed?

removedRanges should be defined and have a positive length before it is assumed that media was ejected from the buffer.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.5.0 milestone Oct 18, 2023
@robwalch robwalch merged commit 9ba35c9 into master Oct 18, 2023
15 of 16 checks passed
@robwalch robwalch deleted the task/mms-removed-ranges-not-null branch October 18, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant