Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use addEventListener for MediaKeySession events #6030

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Dec 11, 2023

This PR will...

Use addEventListener for MediaKeySession events

Why is this Pull Request needed?

It appears that legacy versions of Chrome (53) do no support the onmessage and onkeystatuseschange callback handlers.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Fixes #6034

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.5.0 milestone Dec 11, 2023
@robwalch robwalch force-pushed the bugfix/eme-media-key-session-add-event-listener branch from 3fac248 to bed32d0 Compare December 12, 2023 16:51
@robwalch robwalch merged commit 8ec7215 into master Dec 13, 2023
16 of 17 checks passed
@robwalch robwalch deleted the bugfix/eme-media-key-session-add-event-listener branch December 13, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"license-request" message missed on LG2019 after mediaKeysSession.generateRequest resolved
1 participant