Fix fetch loader abort in progressive mode #6066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Abort fetch loader as long as loading has not ended.
Why is this Pull Request needed?
Fetch response.ok is true as soon as status 200 is returned. In progressive mode, this is set and can be read before all data is loaded and the handling the response is complete.
Are there any points in the code the reviewer needs to double check?
Instead of checking the response status,
!stats.loading.endindicates that loading is incomplete and it is OK to abort.stats.loading.endis only set after receiving all data and handling the final response before invoking the loaderonSuccesscallback.Resolves issues:
Fixes #6054
Checklist