Account for overlapping sidx subsegment durations by parsing earlierstPresentationTime #6192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tPresentationTime Fixes #6191
robwalch
deleted the
bugfix/sidx-duration-overlap-earliest-presentation-time
branch
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Account for overlapping sidx subsegment durations by parsing earlierstPresentationTime
Why is this Pull Request needed?
Summing up all sidx box subsegment durations to get segment duration will add muxed audio and video track durations together without accounting for overlap. This bug was introduced with #4849 because earlierstPresentationTime was never parsed and potential for overlap was never taken into account.
Are there any points in the code the reviewer needs to double check?
I found overlapping sidx boxes in media from #1510 but had to change mp4-tools
getDurationtemporarily to ignore trun durations to see the impact that using overlapping durations from sidx boxes would have. This fix has not been verified against #6191 because a sample that reproduces the issue has not been provided.Resolves issues:
Fixes #6191
Checklist