on startObservering we listen to changes for any moc for a given pers…

…istent store
vijayj · Jul 24, 2014 · a72feeb · a72feeb
1 parent 154a9cd
commit a72feeb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/ParcelKit/PKSyncManager.m b/ParcelKit/PKSyncManager.m
@@ -165,7 +165,7 @@ - (void)startObserving
         });
     }];
 
-    [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(managedObjectContextWillSave:) name:NSManagedObjectContextWillSaveNotification object:self.managedObjectContext];
+    [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(managedObjectContextWillSave:) name:NSManagedObjectContextWillSaveNotification object:nil];
 }
 
 - (void)stopObserving
@@ -175,7 +175,7 @@ - (void)stopObserving
     self.persistentStoreCoordinator = nil;
 
     [self.datastore removeObserver:self];
-    [[NSNotificationCenter defaultCenter] removeObserver:self name:NSManagedObjectContextWillSaveNotification object:self.managedObjectContext];
+    [[NSNotificationCenter defaultCenter] removeObserver:self name:NSManagedObjectContextWillSaveNotification object:nil];
 }
 
 #pragma mark - Updating Core Data
@@ -266,7 +266,7 @@ - (void)managedObjectContextWillSave:(NSNotification *)notification
     if (![self isObserving]) return;
 
     NSManagedObjectContext *managedObjectContext = notification.object;
-    if (self.managedObjectContext != managedObjectContext) return;
+    if (self.managedObjectContext.persistentStoreCoordinator != managedObjectContext.persistentStoreCoordinator) return;
 
     NSSet *deletedObjects = [managedObjectContext deletedObjects];
     for (NSManagedObject *managedObject in [self syncableManagedObjectsFromManagedObjects:deletedObjects]) {

diff --git a/ParcelKitTests/PKSyncManagerTests.m b/ParcelKitTests/PKSyncManagerTests.m
@@ -220,10 +220,10 @@ - (void)testStartObservingShouldObserveDatastore
     [self.datastore verify];
 }
 
-- (void)testStartObservingShouldObserveManagedObjectContext
+- (void)testStartObservingShouldObserveAllChangesToMoc
 {
     id mockNotificationCenter = [OCMockObject niceMockForClass:[NSNotificationCenter class]];
-    [[mockNotificationCenter expect] addObserver:self.syncManager selector:[OCMArg anySelector] name:NSManagedObjectContextWillSaveNotification object:self.syncManager.managedObjectContext];
+    [[mockNotificationCenter expect] addObserver:self.syncManager selector:[OCMArg anySelector] name:NSManagedObjectContextWillSaveNotification object:nil];
 
     id mockNotificationCenterClass = [OCMockObject mockForClass:[NSNotificationCenter class]];
     [[[mockNotificationCenterClass expect] andReturn:mockNotificationCenter] defaultCenter];