Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update misc #385

Merged
merged 12 commits into from
Sep 17, 2024
Merged

update misc #385

merged 12 commits into from
Sep 17, 2024

Conversation

brillout
Copy link
Member

@brillout brillout commented Sep 16, 2024

No description provided.

@brillout brillout marked this pull request as ready for review September 16, 2024 17:45
@brillout brillout force-pushed the brillout/update-misc branch 3 times, most recently from 424abb4 to fa486f6 Compare September 16, 2024 18:37
@brillout
Copy link
Member Author

Still a draft, let me test if I broke something.

@brillout brillout force-pushed the brillout/update-misc branch 2 times, most recently from 6d401e3 to f63d693 Compare September 16, 2024 18:58
@brillout
Copy link
Member Author

This 90f02ff doesn't work: the comment is missing in the generated boilerplate. I guess we can ignore this, it isn't important. Feel free to revert or leave that commit.

@brillout
Copy link
Member Author

I didn't run the CI (my machine is probably too slow 😀) but I manually tested the following and seems like I didn't introduce any bug.

node packages/cli/dist/index.js --react --telefunc --hono
node packages/cli/dist/index.js --vue --telefunc --hono
node packages/cli/dist/index.js --solid --telefunc --hono

This PR is ready for review.

@brillout
Copy link
Member Author

brillout commented Sep 17, 2024

This 90f02ff doesn't work: the comment is missing in the generated boilerplate. I guess we can ignore this, it isn't important. Feel free to revert or leave that commit.

Actually, I guess the best would be to remove global.d.ts (previously vike.d.ts) if it's empty but I don't know whether it's easy to achieve.

@magne4000
Copy link
Member

magne4000 commented Sep 17, 2024

This 90f02ff doesn't work: the comment is missing in the generated boilerplate. I guess we can ignore this, it isn't important. Feel free to revert or leave that commit.

Actually, I guess the best would be to remove global.d.ts (previously vike.d.ts) if it's empty but I don't know whether it's easy to achieve.

Shouldn't be too difficult to implement. I created an issue to follow up on this.

@magne4000 magne4000 merged commit dc309cd into main Sep 17, 2024
8 checks passed
@magne4000 magne4000 deleted the brillout/update-misc branch September 17, 2024 13:04
@magne4000
Copy link
Member

Thanks!

@brillout
Copy link
Member Author

This 90f02ff doesn't work: the comment is missing in the generated boilerplate. I guess we can ignore this, it isn't important. Feel free to revert or leave that commit.

Actually, I guess the best would be to remove global.d.ts (previously vike.d.ts) if it's empty but I don't know whether it's easy to achieve.

Shouldn't be too difficult to implement. I created an issue to follow up on this.

👍 I went ahead and reverted the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants