Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update home.html #356

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pratikktiwari
Copy link

@pratikktiwari pratikktiwari commented Oct 3, 2020

Changed CSS float which caused problems with smaller screens.
Used @media query: When screen with is lesser than 900px i.e., in case of mobile devices, reduce the padding of h2 and clear float.

Description

The float attribute attached to each tank container caused problems in devices with smaller screens.
h2 attribute was assigned padding of about 200px which was also causing problems.
Writing a simple media query for h2 and float worked and solved the issue.

Fixes # (issue)
BEFORE FIX
image

AFTER FIX
image

Type of change

Fix of CSS of home.html

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Reviewer: Vinit Shahdeo

Changed CSS float which caused problems with smaller screens.
Used @media query: When screen with is lesser than 900px i.e., in case of mobile devices, reduce the padding of h2 and clear float.
@welcome
Copy link

welcome bot commented Oct 3, 2020

Thanks for opening this pull request! 🤗
Wishing you a great Hacktoberfest 2020 🙌 🎉 ⚡️
Are you looking for more beginner-friendly issues? Check out this repo.

Hacktoberfest2020

📢 Spread the word about @vinitshahdeo/Hacktoberfest2020 repo across your social media channels to help get others involved! Give a shoutout to DEV article. Retweet this.

Open Source Love

Check out few other repos below 🚀

PortScanner
SimpleBio
HBD
Map Of India

Show some ❤️

  • Consider leaving a ⭐ here.
  • Check out more beginner-friendly repos here.
  • Follow @vinitshahdeo for more updates.
  • Read my open-source journey here.

Say Hi on Twitter! 👋

Twitter Follow

PS: Please add @vinitshahdeo as a reviewer if you haven't added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant